Qiskit / qiskit / 8470697090
89%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 821
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.339% (-0.06%) from 89.396%
8470697090

push

github

web-flow 
Oxidize two qubit basis decomposer (#12010)

* Oxidize TwoQubitBasisDecomposer

This commit is the second part of migrating the default 2q unitary
synthesis method to leverage parallel rust as described in #8774. The
Eventual goal is to be able to run unitary synthesis in parallel for all
the unitary matrices in a single call from the `UnitarySynthesis` pass.
The TwoQubitBasisDecomposer class is one of the default decomposers used
by the unitary synthesis plugin. After this we can build an interface
that will run the decomposition in parallel for a given decomposer.

This commit re-implements the TwoQubitBasisDecomposer class in rust. It
keeps the same algorithm from the previous python version but implements
it in rust. This builds off of #11946 and for the operation of the
decomposer class the TwoQubitWeylDecomposition class is used solely
through rust.

This commit depends on #11946 and will need to be rebased after #11946
is merged.

Fixes #12004

* Fix errors after rebase

* Fix traces method

* Fix pulse optimized synthesis

* Add release notes

* Fix lint

* Use consts for static decomposition arrays

* Run cargo fmt

* Handle basis_fidelity inside unitary synthesis path

* Cast input to TwoQubitBasisDecomposer.num_basis_gates

* Use statics instead of consts

* Pre-allocate 2q circuit sequence outside the pulse optimal path.

590 of 681 new or added lines in 4 files covered. (86.64%)

22 existing lines in 5 files now uncovered.

60237 of 67425 relevant lines covered (89.34%)

231686.08 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
90.7
 0.0% crates/accelerate/src/convert_2q_block_matrix.rs
4
90.04
 -0.7% qiskit/transpiler/passes/synthesis/unitary_synthesis.py
5
93.61
 -1.42% qiskit/synthesis/two_qubit/two_qubit_decompose.py
80
89.33
 -1.64% crates/accelerate/src/two_qubit_decompose.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
93.61
 -1.42% qiskit/synthesis/two_qubit/two_qubit_decompose.py
1
89.33
 -1.64% crates/accelerate/src/two_qubit_decompose.rs
4
92.88
 -0.25% crates/qasm2/src/lex.rs
6
97.61
 0.46% crates/qasm2/src/parse.rs
10
89.78
 -1.26% crates/accelerate/src/euler_one_qubit_decomposer.rs
Jobs
ID Job ID Ran Files Coverage
1 8470697090.1 821
89.34
 GitHub Action Run
Source Files on build 8470697090