binary-com / deriv-app / 8464463431

54%

Build Type

push

github

Committed by web-flow

Commit Message

[WALL] Nijil / WALL-3488 / Application crashes after trading accounts creation in Trader's Hub (#14183)

* feat: useAccountList hook

* fix: infinite useEffect loop

* chore: remove useAccountList hook

* chore: handle useEffect infinite loops by removing the useModal() dependancies

* chore: update useDerivAccountsList hook

* fix: undefined balance caused application crash

* chore: remove unused import

* feat: select default account

* feat: remove unneded condition

* feat: missing else

* feat: fixed default behavriour

* feat: removed unnecesay tests

* feat: removed unused imports

* chore: remove unwanted imports and variables

* fix: types and other fixes

* fix: type error

* fix: eslint error

* fix: memory leak due to useDerivAccountList hook

* fix: options listing not updating after adding trading account

* fix: apply changes based on comments received

* fix: missing item in dependancy array

* fix: handle default wallet if there's no USD wallet

* chore: cleanup

* fix: account creation success modal is not showin in responsive

* fix: apply review comments

* fix: remove unused  type

* chore: rename variables for better clarity

---------

Co-authored-by: Wojciech Brygola <wojciech@regentmarkets.com>

Run Details

15687 of 43546 branches covered (36.02%)

Branch coverage included in aggregate %.

23 of 59 new or added lines in 10 files covered. (38.98%)

9 existing lines in 4 files now uncovered.

25945 of 61828 relevant lines covered (41.96%)

11.53 hits per line