Azure / aks-app-routing-operator / 8458509189

79%

push

github

defaultSSLCertificate via key vault URI (#166)

* moving changes from aamgayle/crdwatchreconciler to new verified branch

* unit tests for nginx_ingress_controller and parameter adjustments

* tests and fix for app-routing-system namespace

* keyVaultUri to pointer and associated changes

* Generic BuildSPC function and namespace fixes

* placeholder_pod refactor and additional nic kv uri e2e test

* obj to nic bug fix, ing annotation change and unit test adjustment

* changed nginx_secret_provider_class namespace to come from config

* Added CEL validation for keyvault fields and properties size on DefaultSSLCertificate

* addressing comments and added placeholder pod check test

* Added e2e tests to confirm pulling secret from keyvault

* error checking for spc get

* removing unneeded upsert of nic

* added secretproviderclass to scheme

* added wait time to ensure spc is found after nic is created

* addressing comments

* removed waits for spc and service in e2e test

* Reverted from zap to logr.Discard

* Addressing comments

* typo fix

* Addressing comments

* Added tests for buildDeployment and moved buildSPC tests to kv_util_test

* ingressClassName error check test

* string fix in test

* Error() and ToPtr fix

* UserError function and better error checking

* changes for UserError

* addressing comments

* typo fix

* test fixes

* added logging for buildSPC error

* Added logging

* Error level logs

* Addressing comments

* moved logging for placeholder_pod to switch cases

* default case for placeholder_pod

---------

Co-authored-by: Oliver King <olivermerkleyking@gmail.com>

246 of 294 new or added lines in 7 files covered. (83.67%)

2823 of 3527 relevant lines covered (80.04%)

12.28 hits per line