safe-global / safe-client-gateway / 8453420386

93%

main: 89%

Build Type

Pull #1348

github

Committed by fmrsabino

Commit Message

Add support for decoding Swap Orders in Multisends

- Swap Orders inside a Multisend should be decoded in the same way as regular ones.
- Detection of a Multisend order happens on the first level of transactions (i.e. it does not detect Swap transactions if a Multisend contains another Multisend).
- The `mapSwapOrder` function also changed:
  * It is no longer restricted to a `MultisigTransaction` or `ModuleTransaction` – this was done to support nested transactions which do not have all the properties of a Multisig or Module transactions.
  * It no longer maps to a `CustomTransactionInfo` – this is now a decision left for the callers. Instead, the promise is rejected if the swap transaction couldn't be decoded successfully.

Pull Request Pull Request #1348: Add support for decoding Swap Orders in Multisends

Run Details

1856 of 2244 branches covered (82.71%)

Branch coverage included in aggregate %.

25 of 35 new or added lines in 3 files covered. (71.43%)

1 existing line in 1 file now uncovered.

6493 of 6719 relevant lines covered (96.64%)

362.91 hits per line