kewisch / ical.js / 8437021987

98%

push

github

Quote (or don't quote) parameter property values individually before joining

Instead of adding quotes to the delimiting comma and around the outside, quote the individual members separately if necessary.
This prevents the whole string of multiple values being quoted because of the presence of a delimiting comma.

When quotes are required (multiValueSeparateDQuote is true) only URIs are valid, which will get quoted due to the colon.
When not required only specific strings (WORK, VOICE, PARCEL, etc.) are valid, none of which need quotes.

1875 of 1925 branches covered (97.4%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 2 files covered. (100.0%)

9290 of 9457 relevant lines covered (98.23%)

5406.43 hits per line