Gallopsled / pwntools / 8413150689

74%

dev: 74%

Build Type

push

github

Committed by peace-maker

Commit Message

Return buffered data on first EOF in tube.readline()

When there is still data available in the tube buffer when an EOFError occurs in
`tube.recvline()`, return that data even though it doesn't contain a newline.
The next time `tube.recvline()` is called afterwards will raise EOFError normally.

This behavior is in line with the GNU readline implementation and avoids
loss of data. It allows `tube.stream()` to print everything that's received before
the receiving end terminates.

A new warning is logged when data is returned due to an EOF informing
about the lack of the trailing newline character.

Fixes #2366

Run Details

4654 of 7389 branches covered (62.99%)

7 of 7 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

13032 of 17509 relevant lines covered (74.43%)

0.74 hits per line