rust-bitcoin / rust-bitcoin / 8396682813

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2549: improve relative locktime API

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/04715e3e60de6e288727154e75e895b2b7447d35">04715e3e6<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/38514412653955907e19c8f50e439b6533f2a4a1"> absolute: make is_* methods uniform with the ones from relative (Andrew Poelstra)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/878b865f855e3c67ab9a211f33a229d897b4451a">878b865f8</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/38514412653955907e19c8f50e439b6533f2a4a1"> relative locktime: introduce is_* methods to check units (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c2f87c7ab3cac927f2fa52bfca050585681e48ad">c2f87c7ab</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/38514412653955907e19c8f50e439b6533f2a4a1"> relative locktime: add is_implied_by method for sequences (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/319e102fed6bcf9d6c2a2d68a62d20ce9200eb7c">319e102fe</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/38514412653955907e19c8f50e439b6533f2a4a1"> relative locktime: use From/TryFrom to convert between relative locktimes and Sequence (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0ed26915f6d1000f1fd48214a5da639306b13edf">0ed26915f</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/38514412653955907e19c8f50e439b6533f2a4a1"> relative locktime: add conversions to/from sequence (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5c8fb5c11b99cfbceed38a8a02a56785eeb7f49e">5c8fb5c11</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/38514412653955907e19c8f50e439b6533f2a4a1"> relative locktime: add consensus encode/decode functions (Andrew Poelstra)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ac968e02b60b039ece43ab92a855bac3a310474b">ac968e02b relative locktime: constify a bunch of constructors (Andrew Poelstra)
f27e675e1 relative locktime: add "obvious" constructors (Andrew Poelstra)
f02b1dac5 relative locktime: copy comments and PartialOrd impl from absolute locktimes (Andrew Poelstra)
2ff5085e7 locktimes: run cargo fmt (Andrew Poelstra)

Pull request description:

  While implementing https://github.com/rust-bitcoin/rust-miniscript/pull/654 I ran into a number of limitations of the `relative::LockTime` API. This fixes these by

  * Copying a ton of functions from `absolute::LockTime` to `relative::LockTime`, adjusting comments and functionality accordingly.
  * Adding conversion functions to/from `Sequence` numbers, as well as a method to check whether a locktime is satisfied by a given sequence number.

  Fixes #2547
  Fixes #2545
  Fixes #2540

ACKs for top commit:
  tcharding:
    ACK 04715e3e60de6e288727154e75e895b2b7447d35
  sanket1729:
    ACK 04715e3e60de6e288727154e75e895b2b7447d35

Tree-SHA512: 70740eaa31ae881d81712707ad6fb949c4e28183... (continued)

Run Details

41 of 120 new or added lines in 4 files covered. (34.17%)

4 existing lines in 3 files now uncovered.

19041 of 22824 relevant lines covered (83.43%)

16984.24 hits per line