Ouranosinc / xscen / 8379993792

87%

push

github

Test conversions (#372)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Tests for `xclim_modules/conversions.py`
* Added `context="hydro"` to the precipitation conversion.
* Fixed a bug in `tasmin/max_from_dtr` when `dtr` was in different units
than `tasmin/max`.

### Does this PR introduce a breaking change?

* I changed `dtr` (the function) to `dtr_from_minmax` to avoid conflicts
with `dtr` (the variable). This is only breaking if people directly used
the Python file, which should be no one.


### Other information:

10 of 10 new or added lines in 1 file covered. (100.0%)

2965 of 4023 relevant lines covered (73.7%)

5.78 hits per line