openSUSE / agama / 8374097791

72%

Build Type

push

github

Committed by web-flow

Commit Message

[Service] Alternative location for volumes (#1105)

## Problem

The storage proposal allows to specify what to do in order to allocate
any volume:

- Use the default location (new partition or new LV)
- Create it in a given disk as a new partition
- Create it as a new LV in a new dedicated VG on top of a given disk
- Reformat an existing device
- Mount an existing device

Everything is possible, no matter whether the default target is a disk
or a new LVM VG.

So far, it was not possible to use the Agama D-Bus settings to specify
that to the proposal, so all volumes always used the default location.

## Solution

This adds two new attributes to the D-Bus definition of a volume:
`Target` and `TargetDevice`.

Internally, this is represented by a new class `VolumeLocation` with two
attributes:
  - `target`: which specifies how to allocate the volume
- `device`: the name of the target device, the exact meaning depends on
`target`

The new class and the possible targets follow the same approach of
`SpaceSettings` and its policies.

## Testing

- Added several unit tests
- Tested manually by hacking the web UI a bit (see screenshots below)

## Screenshots

Hacking the web UI to set Target to `filesystem` and TargetDevice to
`/dev/vdb5` (which contains a Btrfs file system).


![mount-new](https://github.com/openSUSE/agama/assets/3638289/9a8d83ea-b946-4fe6-b850-3058fdd353ca)

Hacking the web UI to set Target to `new_vg` and TargetDevice to
`/dev/vdc`.


![vg-new](https://github.com/openSUSE/agama/assets/3638289/ed90a87d-ac8e-45d0-85cf-4eff9f62f890)

Run Details

1639 of 2432 branches covered (67.39%)

Branch coverage included in aggregate %.

47 of 49 new or added lines in 6 files covered. (95.92%)

2 existing lines in 1 file now uncovered.

17570 of 23237 relevant lines covered (75.61%)

24.63 hits per line