tarantool / tarantool / 8357367449

88%

Build Type

push

github

Committed by ImeevMA

Commit Message

sql: rework OP_SetDiag opcode

Prior to this patch, the OP_SetDiag opcode accepted an error code and
error description, which already included the description from the error
code. But this makes #9108 more difficult, so now the accepted error
description does not include the description from the error code.

Note that this change is possible because all accepted error codes use
exactly one argument.

Additionally, this patch removes p4 from the OP_Halt opcode in one
place, since OP_Halt only uses p1 and p2 and does not use p4. Moreover,
the address specified in p4 may not be available by the time OP_Halt is
executed.

Needed for #9108

NO_DOC=internal
NO_TEST=internal
NO_CHANGELOG=internal

Run Details

67080 of 119515 branches covered (56.13%)

15 of 15 new or added lines in 5 files covered. (100.0%)

20 existing lines in 11 files now uncovered.

99615 of 114511 relevant lines covered (86.99%)

2759246.12 hits per line