rust-bitcoin / rust-bitcoin / 8318043190

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2039: Add a `consensus::deserialize_hex` function

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/16a813734cedfd7980c5aa7562bd097a07acceff">16a813734 Implement consensus deserialize_hex (Tobin C. Harding)

Pull request description:

  We have `serialize_hex` and `deserialize` but no `deserialize_hex`, add it.

  Move the `IterReader` out of `consensus::serde` to the `consensus` module.

  Add some additional logic to the `DecodeError`, I'm not sure why this wasn't there before?

  Use the `HexSliceToBytesIter` by way of the `IterReader` to deserialize an arbitrary hex string. Add unit tests to check that we consume all bytes when deserializing a fixed size object (a transaction).

ACKs for top commit:
  apoelstra:
    ACK 16a813734cedfd7980c5aa7562bd097a07acceff
  sanket1729:
    ACK 16a813734cedfd7980c5aa7562bd097a07acceff

Tree-SHA512: 121285cb31613d44c5a7c3d2aff7493d2e4

Run Details

37 of 101 new or added lines in 2 files covered. (36.63%)

1 existing line in 1 file now uncovered.

19750 of 23562 relevant lines covered (83.82%)

16363.95 hits per line