c-ares / c-ares / #712

92%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Replace configuration file parsers with memory-safe parser (#725)

Rewrite configuration parsers using new memory safe parsing functions.
After CVE-2024-25629 its obvious that we need to prioritize again on
getting all the hand written parsers with direct pointer manipulation
replaced. They're just not safe and hard to audit. It was yet another
example of 20+yr old code having a memory safety issue just now coming
to light.

Though these parsers are definitely less efficient, they're written with
memory safety in mind, and any performance difference is going to be
meaningless for something that only happens once a while.

Fix By: Brad House (@bradh352)

Run Details

360 of 422 new or added lines in 7 files covered. (85.31%)

6 existing lines in 4 files now uncovered.

8255 of 10228 relevant lines covered (80.71%)

3832.88 hits per line