rust-bitcoin / rust-bitcoin / 8303149431

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2569: Move types to `units`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/cbee9781e88bb861919191bec2bcf7ed2604128b">cbee9781e<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/750b4dfb8b38bc1b7f4e721c7e8847607ca8e43f"> Move unit types to units (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5bd0d7194b3c53fcbfc15a83f340dc4dd4cefe14">5bd0d7194</a> Remove unused absolute::Error (Tobin C. Harding)

Pull request description:

  Move the following unit types to the new `units` crate:

  - `locktime::absolute::{Height, Time}`
  - `locktime::relative::{Height, Time}`
  - `FeeRate`
  - `Weight`

  Also move the `parse` module as well as constants as required.

  Do minimal changes to get things building:

  - Feature gate on "alloc" as needed.
  - Remove rustdocs that use `bitcoin` types.
  - Re-export units types so this is a non-breaking change.
  - Fix import paths.

  Patch 1 was originally #2526, putting it in via this PR to try and speed up the process.

  Close: #2282

ACKs for top commit:
  sanket1729:
    ACK cbee9781e88bb861919191bec2bcf7ed2604128b
  apoelstra:
    ACK cbee9781e88bb861919191bec2bcf7ed2604128b lgtm. this is a good start. I think the LockTime types should follow Height and Time

Tree-SHA512: 6b0d63c7b3b5529d79b488700898eac5f87

119 of 228 new or added lines in 7 files covered. (52.19%)

19697 of 23476 relevant lines covered (83.9%)

16476.51 hits per line