qmonnet / rbpf / 8295957665

95%

push

github

src/interpreter: Remove/explain masks for 32-bit shift operations

We recently fixed the 64-bit arithmetic shift-right operations by adding
a mask to the number of bits (as immediates or from the source register)
by which to shift, as per the eBPF ISA specification. The 32-bit
operations must use the same mask, but .wrapping_shr() already takes
care of it for us. Let's add a comment to make it explicit.

As it turns out, masking is just as well unnecessary for the
non-arithmetic left-right shift operations that we tried to fix
recently. Let's also remove the mask there.

Signed-off-by: Quentin Monnet <qmo@qmon.net>

4 of 4 new or added lines in 1 file covered. (100.0%)

4147 of 4333 relevant lines covered (95.71%)

241.82 hits per line