8285511681
53%

Ran 14 Mar 2024 06:08PM UTC

Jobs 1

Files 141

Run time 1min

Badge

Embed ▾

Committed 14 Mar 2024 06:04PM UTC coverage: 46.885% (+0.01%) from 46.871%

Build # 8285511681

Build Type

push

github

Committed by

web-flow

Commit Message

Make the parameter of GetRepositoryByName and DeleteRepositoryByName greedy (#2655)

The grpc gateway unescapes all paths by default:
https://grpc-ecosystem.github.io/grpc-gateway/docs/mapping/customizing_your_gateway/#controlling-path-parameter-unescaping

This means that parameters that do contain slashes don't work by default
as they are presumed part of the URL and not routed correctly.

This patch changes the parameter of DeleteRepositoryByName and
GetRepositoryByName to be "greedy", meaning that everything after the
static part of the path is considered a parameter.

example curls that now work:
```
curl -H "Authorization: Bearer $MINDER_BEARER_TOKEN"
'http://localhost:8080/api/v1/repository/name/jakubtestorg%2Fbad-python?context.project=8f701090-efb9-477e-983a-39a34cb73b42&context.provider=github'
```
and:
```
curl -XDELETE -H "Authorization: Bearer $MINDER_BEARER_TOKEN"
'http://localhost:8080/api/v1/repository/name/jakubtestorg%2Fbad-python?context.project=8f701090-efb9-477e-983a-39a34cb73b42&context.provider=github'
```

Fixes: #2654

Run Details

6818 of 14542 relevant lines covered (46.88%)

42.26 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	8285511681.1	14 Mar 2024 06:08PM UTC	0	46.88	GitHub Action Run

Source Files on build 8285511681

Detailed source file information is not available for this build.

stacklok / minder / 8285511681
53%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8285511681

stacklok / minder / 8285511681 53%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8285511681

stacklok / minder / 8285511681
53%

README BADGES
x