rust-bitcoin / rust-bitcoin / 8276893111

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2576: Return error when constructing pubkey from slice

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/6ecc41d126621862fe2392c7ab510e2ef9ecc960">6ecc41d12 Return error when constructing pubkey from slice (Tobin C. Harding)

Pull request description:

  This PR fixes a bug introduced by me in #2473, and uncovered by #2563 - amazing that it was found so quickly!

  Constructing a pubkey using `PublicKey::from_slice` can fail for reasons other than just incorrect length - we should not be using `expect` but rather returning the error.

  A purist might argue that we are now returning a nested error type with an unreachable variant:

    `ParsePublicKeyError::Encoding(FromSliceError::InvalidLength)`

  Is this acceptable or do we want to further improve this?

ACKs for top commit:
  sanket1729:
    ACK 6ecc41d126621862fe2392c7ab510e2ef9ecc960
  apoelstra:
    ACK 6ecc41d126621862fe2392c7ab510e2ef9ecc960

Tree-SHA512: ae8299b21a29b78c305ce028235a7ca1737

2 of 2 new or added lines in 1 file covered. (100.0%)

19667 of 23373 relevant lines covered (84.14%)

16477.31 hits per line