charmbracelet / bubbles / 8275750516

37%

master: 45%

Build Type

Pull #496

github

Committed by mikelorant

Commit Message

refactor(textarea): Improve setting width

When setting the width of the textarea there were some issues
preventing this from working correctly. These problems included:

- If the maximum width needed to be used, the width of the textarea did
  not take into account the prompt and line number width.
- The viewport width did not take into account the style width.

The entire function was confusing to understand and a refactor was
warranted.

As part of this refactor, the bugs mentioned above were fixed and the
code was simplified.

To verify that the logic works as expected, unit tests were expanded to
validate that setting the width works as expected.

Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>

Pull Request Pull Request #496: refactor(textarea): Improve setting width

Run Details

18 of 18 new or added lines in 1 file covered. (100.0%)

103 existing lines in 1 file now uncovered.

1558 of 4197 relevant lines covered (37.12%)

69.52 hits per line