Unleash / unleash-edge / #1039

79%

push

fix: handle incoming requests on the api level (#443)

Update all endpoints of the frontend_api to accept top-level properties.

This is primarily just changing the type we expect and then, on the lower level functions, converting the incoming context into a regular context.

Most of the functions are pretty straight-forward. get_all_features appears to be the only one that doesn't share an implementation with any other functions.

The tests check:

-    /api/frontend/features/:feature (/api/proxy/features/:feature uses the same impl under the hood, so I've not tested that explicitly. Happy to change that though.
-   GET /api/{frontend,proxy}(/all)?
-    POST /api/{frontend,proxy) (POST all features function takes an IncomingContext as a parameter, so I'm assuming the serialization here works; can of course add tests for that too)
-    That providing a string as the value of properties yields a 400

6 of 7 new or added lines in 1 file covered. (85.71%)

1211 of 1532 relevant lines covered (79.05%)

1.81 hits per line