spesmilo / electrum / 4918879474941952

63%

Build Type

push

CirrusCI

Committed by SomberNight

Commit Message

swaps: use longer final_cltv_delta for client-normal-swap

This gives more time for the client to come back online.

see https://github.com/spesmilo/electrum/issues/8940

- re note on submarine_swaps.py#L53:
  lnpeer.Peer.maybe_fulfill_htlc only checks against MIN_FINAL_CLTV_DELTA_ACCEPTED(=144),
  so this increased cltv_delta is not enforced when receiving the htlc on ln.
  It is put in the invoice, so the sender is supposed to honour it ofc.
  It would be nice to enforce it (make the check in maybe_fulfill_htlc dependent on
  what was in the invoice).

Run Details

2 of 4 new or added lines in 2 files covered. (50.0%)

51 existing lines in 20 files now uncovered.

19691 of 32620 relevant lines covered (60.36%)

3.62 hits per line