evolution-gaming / kafka-journal / 8248530959
82%
master: 83%

LAST BUILD BRANCH: update/logback-classic-1.5.14
DEFAULT BRANCH: master
Ran
Jobs 1
Files 191
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.787% (-0.1%) from 81.91%
8248530959

Pull #594

rtar 
Move `CassandraConsistencyConfig` from `eventual.cassandra` to `cassandra` package.

**Reasoning**

As part of restoring binary compatibility with a previous version, I am
going to copy-paste several classes such as `CassandraHealthCheck`,
`SettingsCassandra`, `SettingsStatements` and related classes to
`eventual-cassandra` project, so they could depend on a restored
`EventualCassandraConfig.ConsistencyConfig`.

To make sure there is no conflict between the two copies, I will move
the classes in `cassandra` project from `eventual.cassandra` to
`cassandra` package instead.

The classes from `eventual-cassandra` will use the old signatures, and
will be the simple wrappers of `cassandra` classes.

But before I do all this, I will move `CassandraConsistencyConfig` to
that `cassandra` package, because it is a part of new API.

To summarize:

`com.evolutiongaming.kafka.journal.cassandra` package in `cassandra`
project - will contain new common cassandra API used both by journaller
and snapshotter,

`com.evolutiongaming.kafka.journal.eventual.cassandra` package in
`eventual-cassandra` project - will contain an API used by journaller
only, including the legacy wrappers needed to maintain a binary
compatiblity with a previous version.

**Tricky questions**

*Why cannot you copy `EventualCassandraConfig` to `cassandra` instead?*

Because it contains dependencies on journaller specific classes such as
`SchemaConfig` or `SegmentSize`.
Pull Request #594: Move `CassandraConsistencyConfig` from `eventual.cassandra` to `cassandra` package

3314 of 4052 relevant lines covered (81.79%)

1.33 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
6
90.83
 -2.75% eventual-cassandra/src/main/scala/com/evolutiongaming/kafka/journal/eventual/cassandra/ReplicatedCassandra.scala
Jobs
ID Job ID Ran Files Coverage
1 Scala 2.13.12 - 8248530959.1 191
81.79
Source Files on build 8248530959