tari-project / tari / 8245040682
74%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 726
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 75.719% (-0.2%) from 75.965%
8245040682

push

github

web-flow 
fix: downgrade crossterm for windows compatibility (#6204)

Description
---
A recent updates `crossterm` to the latest version, `0.27.0`, from
version `0.25.0`. The behaviour of keyboard events on Windows changed
from version `0.26.0` upwards, making the use of the console wallet and
to a lesser degree the base node in Windows Console unusable as multiple
keystrokes events are generated for each keystroke.

This PR did not seek to find a solution for upgrading to the latest
version of `crossterm`, but merely to revert the change.

Motivation and Context
---
See above.

How Has This Been Tested?
---
System-level testing

What process can a PR reviewer use to test or verify this change?
---
Review code changes
System-level testing

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->

Co-authored-by: SW van Heerden <swvheerden@gmail.com>

75017 of 99073 relevant lines covered (75.72%)

305874.22 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
85.54
 -1.2% comms/core/src/pipeline/inbound.rs
1
58.1
 2.86% base_layer/core/src/mempool/service/service.rs
2
74.76
 0.0% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
2
77.72
 0.0% base_layer/wallet/src/transaction_service/protocols/transaction_send_protocol.rs
2
88.79
 -0.11% comms/dht/src/actor.rs
2
52.94
 -0.41% base_layer/core/src/base_node/rpc/service.rs
2
87.31
 -0.04% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
2
44.44
 -7.41% base_layer/wallet/src/transaction_service/tasks/wait_on_dial.rs
2
79.42
 1.08% base_layer/wallet/src/transaction_service/protocols/transaction_receive_protocol.rs
3
30.0
 -6.67% base_layer/wallet/src/transaction_service/error.rs
4
83.26
 -0.85% comms/core/src/noise/socket.rs
9
88.61
 -5.7% comms/dht/src/outbound/mock.rs
16
50.42
 -3.33% base_layer/wallet/src/output_manager_service/handle.rs
20
53.66
 -3.75% base_layer/wallet/src/transaction_service/handle.rs
92
67.12
 -4.44% base_layer/wallet/src/transaction_service/service.rs
122
56.2
 -6.79% base_layer/wallet/src/output_manager_service/service.rs
Jobs
ID Job ID Ran Files Coverage
1 8245040682.1 726
75.72
 GitHub Action Run
Source Files on build 8245040682