rust-bitcoin / rust-bitcoin / 8239659179

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2473: Upgrade to `hex v0.2.0`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f337dec2b15c9f8a89cd3cf4f6f93d244aac3b55">f337dec2b<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a124ff41c4cb4e22d7c0ecb1d539b1ba306b2603"> hashes: Remove unnecessary feature guard from test (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0cea90d505c0741220bf902ecf22ca5d87333375">0cea90d50</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a124ff41c4cb4e22d7c0ecb1d539b1ba306b2603"> Test hashes honour Formatter::precision (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/4bfb466bb959bddc3aed96aeed74b4ebcc13176b">4bfb466bb</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a124ff41c4cb4e22d7c0ecb1d539b1ba306b2603"> Upgrade hex dependency (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f0558e8eb9743381a2ef3b83de1fb894dfdc8ff8">f0558e8eb</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a124ff41c4cb4e22d7c0ecb1d539b1ba306b2603"> Use fmt_hex_exact (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6820f5140873813e7d74c19d4725578dba1d5cec">6820f5140</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a124ff41c4cb4e22d7c0ecb1d539b1ba306b2603"> hashes: Add fmt roundtrip tests (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e302e30e7c1eb786debbaa476d90bb739b437fee">e302e30e7</a> Import with super::* in unit test (Tobin C. Harding)

Pull request description:

  Upgrade to use the newly released `hex` code.

  - Patch 1: Does trivial preparatory cleanup
  - Patch 2: Adds some unit tests to check we roundtrip hashes correctly (added because in the test PR I had the `Midstate` iml wrong and it was not being caught).
  - Patch 3: Uses macro in place of `forward_hex` and `backward_hex` - needs concept review, I hacked this without understanding why the functions existed in the first place.
  - Patch 4: Does the upgrade, I've attempted to make minimal changes, so there is room for a bunch of cleanups if/when this merges.
  - Patch 5: Adds a unit test to verify that we can close #2494
  - Patch 6: Removes unnecessary feature gate from unit test.

ACKs for top commit:
  Kixunil:
    ACK f337dec2b15c9f8a89cd3cf4f6f93d244aac3b55
  apoelstra:
    ACK f337dec2b15c9f8a89cd3cf4f6f93d244aac3b55

Tree-SHA512: 7913d1b3026c8f27bbb3d90d47cd129bded

Run Details

64 of 79 new or added lines in 11 files covered. (81.01%)

4 existing lines in 1 file now uncovered.

19540 of 23250 relevant lines covered (84.04%)

16647.18 hits per line