babelfish-for-postgresql / babelfish_extensions / 8236543022

74%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Populate the dbid column of babelfish_extended_properties during restore (#2382) (#2419)

Previously, there were two issues with the dump of `babelfish_extended_properties`
catalog table:  
1. Current restore logic requires that `babelfish_sysdatabases` table's data gets restored first before any other table containing `dbid` column so that we generate the `dbid` once in the beginning and use it for all the remaining tables. But it was not the case yet.
2. `sql_variant` column handling was not there for catalog table's data but  `babelfish_extended_properties` contains it.

The engine side commit fixes both the above two issues so that we correctly dump the data of `babelfish_extended_properties` catalog.

Engine PR: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/314

This commit adds handling to populate  the dbid column of babelfish_extended_properties during restore.


### Issues Resolved
https://github.com/babelfish-for-postgresql/babelfish_extensions/issues/2256
Task: BABEL-4720 

Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>

Run Details

2 of 6 new or added lines in 3 files covered. (33.33%)

2 existing lines in 1 file now uncovered.

40471 of 55721 relevant lines covered (72.63%)

57500.53 hits per line