oetiker / znapzend / 95c2bd84e

80%

Build Type

push

github

Committed by web-flow

Commit Message

Handle `enabled=off` with recursion in place (#625)

* lib/ZnapZend.pm: createSnapshot(): be pedantic about "implicit value of org.znapzend:enabled" for sub-datasets

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* lib/ZnapZend.pm: createSnapshot(): update comments about creation and cleanup of snapshots on enabled=off sub-datasets

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* lib/ZnapZend.pm: refactor listDisabledSourceDescendants() out of createSnapshot() so it can also be used in sendRecvCleanup()

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* lib/ZnapZend.pm: refactor listDisabledSourceDescendants() calls to be done in refreshBackupPlans() once

Track the list of names as @{$backupSet->{srcDisabledDescendants}}

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* lib/ZnapZend/Config.pm::checkBackupSets(), lib/ZnapZend.pm::listDisabledSourceDescendants(): recognize sub-datasets that are both enabled(=off|on) and recursive(=on)

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* .github/workflows/spelling/expect.txt: update for PERL source changes

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* CHANGES: update wording about "enabled=off" support

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* README.md: clarify about use of local ZFS properties for ZnapZend configurations

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* README.md: clarify about current support of not-enabled datasets under a recursive backup schedule

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* README.md: update about "enabled=off + recursive=on" setting for sub-tree pruning [#625]

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* lib/ZnapZend.pm: listDisabledSourceDescendants(): avoid changing data type for raw and parsed cmd output [#625 review]

Signed-off-by: Jim Klimov <jimklimov@gmail.com>

* lib/ZnapZend.pm: listDisabledSourceDescendants(): avoid "&&", use "and" [#625 review]

Signed-off-by: Jim ... (continued)

Run Details

57 of 75 new or added lines in 2 files covered. (76.0%)

1 existing line in 1 file now uncovered.

2269 of 2725 relevant lines covered (83.27%)

28392.11 hits per line