openSUSE / agama / 8230343174

72%

Build Type

push

github

Committed by web-flow

Commit Message

Description for adjust_by_ram (#1081)

## Problem

In Agama a volume can have automatic sizes based on one or several of
the following reasons:

- Snapshots
- Fallbacks from other volumes (eg. "/" max size can exist or not based
on the existence of "/home")
- Size of the RAM

The three are already implemented and working. But the third one lacks
the corresponding explanations.

| No information icon in the "auto" label | Incomplete sentence in the
form |
|-|-|
|
![by_ram](https://github.com/openSUSE/agama/assets/3638289/a6a2aedd-b630-4346-8d16-6c2cc2fa6d85)
|
![enlarge](https://github.com/openSUSE/agama/assets/3638289/2f0443ae-a732-40af-a858-f8314d48ad19)
|

## Solution

This pull request introduces the missing messages, so now the proper
information is displayed both in the table of volumes and in the form.

| The "auto" label | The form |
|-|-|
|
![ram-table](https://github.com/openSUSE/agama/assets/3638289/ec742117-6859-462c-8a9c-460c1509bf43)
|
![ram-form](https://github.com/openSUSE/agama/assets/3638289/3fd74029-196c-4b4f-9da5-74e5efbe52e0)
|

The message is "as good as it gets" for the time being. The plan is to
add the size of the RAM to it, but for that we need to improve the Agama
API as reflected at

https://trello.com/c/suiA6MzZ/354-agama-api-for-system-information-like-ram-size

Additionally, this pull request enables `adjust_by_ram` for swap at the
Tumbleweed product, to raise awareness and get feedback.

### About the approach

We can already foresee people asking "where is my 'Enlarge to RAM Size
for Suspend' checkbox"? So let's explain how the approach has changed.
That approach, not only for swap but for so-called volumes in general,
is explained in the section "[Automatic Size
Limits](https://github.com/openSUSE/agama/blob/master/doc/storage_ui.md#automatic-size-limits)"
of the document describing the storage UI.

In the traditional YaST storage proposal users has no direct way to... (continued)

Run Details

1494 of 2273 branches covered (65.73%)

Branch coverage included in aggregate %.

1 of 2 new or added lines in 2 files covered. (50.0%)

47 existing lines in 3 files now uncovered.

16932 of 22571 relevant lines covered (75.02%)

22.89 hits per line