snowplow / enrich / 8191412055

74%

master: 74%

Build Type

Pull #883

github

Committed by benjben

Commit Message

Switch bad row type from EnrichmentFailures to SchemaViolations for some errors

There are 3 places that currently produce an EnrichmentFailures bad row
whereas the more appropriate type is SchemaViolations:

1. When the input fields of the HTTP requests are mapped to the atomic event.
2. When the enrichments contexts get validated.
3. When the atomic fields lengths get validated.

For 1 and 3, the error should be mapped into an Iglu ValidationError
with the atomic schema referenced.

Before this change, if there was any error in the mapping of the atomic fields,
a bad row would get emitted right away and we would not try to validate
the entities and unstruct event. Now all these errors are wrapped inside
a same SchemaViolations bad row.

Likewise, before this change when an enrichment context was invalid,
we were emitting a bad row right away and not checking the lengths of
the atomic fields. Now all these errors are wrapped inside a same
SchemaViolations bad row.

Pull Request Pull Request #883: Switch bad row type from EnrichmentFailures to SchemaViolations for s…

Run Details

108 of 124 new or added lines in 12 files covered. (87.1%)

28 existing lines in 7 files now uncovered.

4039 of 5425 relevant lines covered (74.45%)

1.19 hits per line