safe-global / safe-smart-account / 8188533217

94%

push

github

Using `returndatasize()` in assembly. (#740)

This PR closes #734 by directly using the `returndatasize()` instead of
storing it in memory and retrieving it later. ~Accessing
`returndatasize()` is always cheaper than `mstore` and multiple
`mload`'s~.

On checking further, it was found that there are no differences in terms
of gas usage for transactions (extra tests were added for `MultiSend` to
verify), while 1 byte is saved during deployment (checked using
`codesize`).

Note: Benchmark failing in this PR is expected:
[Source](https://github.com/safe-global/safe-smart-account/pull/736#issuecomment-1934037016)

261 of 292 branches covered (89.38%)

Branch coverage included in aggregate %.

396 of 404 relevant lines covered (98.02%)

97.1 hits per line