Unleash / unleash-client-python / 8187718702

95%

master: 97%

push

github

refactor: cut test execution time (#305)

This PR decreases test execution time for the test_client test suite by about 2 whole minutes (132 seconds, I think).

It does that by extracting the `aggregate_metrics` function and, instead of waiting for the client to actually send metrics, just checking what the metrics would be aggregated to.

In doing so, it might be worth adding another test to ensure that metrics **are** actually sent, but we may or may not already have this elsewhere.

## Type of change

Please delete options that are not relevant.
- [x] Refactor of tests
# How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

- [x] Unit tests

# Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream modules

8 of 8 new or added lines in 2 files covered. (100.0%)

919 of 947 relevant lines covered (97.04%)

0.97 hits per line