• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

IQSS / dataverse / #21725
24%

Build:
DEFAULT BRANCH: develop
Ran 06 Mar 2024 02:12PM UTC
Jobs 1
Files 883
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 Mar 2024 02:06PM UTC coverage: 20.583% (+0.3%) from 20.253%
#21725

push

github

web-flow
IQSS/3623 - Multiple PID Provider support (#10234)

* Switch to per-pid-provider settings

* partial refactor towards non-bean providers

* ~auto refactor name/package, remove bean status

* remove Util class

* rename

* add factories for all, fix providers, etc.

* unmanaged providers

* add getters

* add name to cnstr, add cnstr for unmanaged, add auth/shoulder checks

* update permalinks, add separator setting

* no arg constructor

* add unmanaged providers

* check canManagePid instead

* replace getBean(), compiles except for tests

* update tests, comment out ones that are TBD

* add clear method for testing

* bugs - remove dup authority, fix name, add auth/sep/shoulder tests

* make managed/excluded lists optional

* fix name in generated pids

* move setup to berforeall, add test of second permaprovider

* provider name->id

* adding label, more name->id

* providerName->providerId

* add factory map, lookups, add factory, perma parsing tests

* first datacite parsing test/fix id in pid

* rename class

* move auth/shoulder check to lower level method

* fix ids, fix managed list optional in fake

* add effective pid generator logic

* add effective pid generator tests

* fix param order

* fix perma handling of managed/excluded entries

* add managed/excluded tests, cleanup

* update pidprovider discovery to get effective one when necessary

* replace all refs to global protocol/auth/shoulder settings xcept one

keeping the new PidProviderFactoryBean.getDefaultPidGenerator() for now
as a possible way to stay ~backward comaptible

All the rest - tried to find the appropriate PidProvider to supply the
values

* first UI for setting Pid generator

* typo

* flyway script to add pid spec column

* @AutoService and public class for loader discovery

* minor cleanup/refactor

* verify protocol/auth are set/match the provider plus cleanup

* only call getGlob... (continued)

400 of 1362 new or added lines in 59 files covered. (29.37%)

16 existing lines in 12 files now uncovered.

16977 of 82480 relevant lines covered (20.58%)

0.21 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
0.65
0.02% src/main/java/edu/harvard/iq/dataverse/EjbDataverseEngine.java
1
0.29
0.0% src/main/java/edu/harvard/iq/dataverse/api/imports/ImportServiceBean.java
1
33.33
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/UnmanagedDOIProvider.java
1
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/util/json/JSONLDUtil.java
2
62.22
0.0% src/main/java/edu/harvard/iq/dataverse/DataCitation.java
2
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/PublishDatasetCommand.java
2
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/ReservePidCommand.java
2
89.47
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/datacite/DataCiteProviderFactory.java
2
88.89
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/ezid/EZIdProviderFactory.java
2
86.67
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/fake/FakeProviderFactory.java
2
90.48
src/main/java/edu/harvard/iq/dataverse/pidproviders/handle/HandleProviderFactory.java
2
59.26
src/main/java/edu/harvard/iq/dataverse/pidproviders/handle/UnmanagedHandlePidProvider.java
2
88.89
src/main/java/edu/harvard/iq/dataverse/pidproviders/perma/PermaLinkProviderFactory.java
2
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/settings/ConfigCheckService.java
3
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/api/datadeposit/CollectionDepositManagerImpl.java
3
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/ImportDatasetCommand.java
3
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/UpdateDatasetTargetURLCommand.java
4
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/DvObjectServiceBean.java
4
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/S3PackageImporter.java
4
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/api/Admin.java
4
6.67
0.03% src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java
4
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/batch/jobs/importer/filesystem/FileRecordWriter.java
4
15.79
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/fake/FakeDOIProvider.java
4
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/workflow/WorkflowServiceBean.java
5
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/api/LDNInbox.java
5
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/api/MakeDataCountApi.java
5
9.07
0.0% src/main/java/edu/harvard/iq/dataverse/api/imports/ImportGenericServiceBean.java
5
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/AbstractCreateDatasetCommand.java
5
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/UpdateDvObjectPIDMetadataCommand.java
5
6.12
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/ezid/EZIdDOIProvider.java
7
37.5
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/AbstractDatasetCommand.java
7
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DeleteDataFileCommand.java
8
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DeletePidCommand.java
9
52.88
13.49% src/main/java/edu/harvard/iq/dataverse/DvObjectContainer.java
10
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/DatasetPage.java
10
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DestroyDatasetCommand.java
11
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/CreateNewDatasetCommand.java
11
50.85
17.88% src/main/java/edu/harvard/iq/dataverse/pidproviders/PidUtil.java
13
48.0
src/main/java/edu/harvard/iq/dataverse/pidproviders/perma/UnmanagedPermaLinkPidProvider.java
15
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/RegisterDvObjectCommand.java
15
10.89
src/main/java/edu/harvard/iq/dataverse/pidproviders/handle/HandlePidProvider.java
16
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/api/Pids.java
17
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/DataversePage.java
17
70.69
src/main/java/edu/harvard/iq/dataverse/pidproviders/perma/PermaLinkPidProvider.java
24
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/FinalizeDatasetPublicationCommand.java
30
38.78
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/AbstractDOIProvider.java
34
0.19
-0.0% src/main/java/edu/harvard/iq/dataverse/api/Datasets.java
98
4.85
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/datacite/DOIDataCiteRegisterService.java
99
1.0
src/main/java/edu/harvard/iq/dataverse/pidproviders/PidProviderFactoryBean.java
123
6.82
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/datacite/DataCiteDOIProvider.java
144
30.43
src/main/java/edu/harvard/iq/dataverse/pidproviders/AbstractPidProvider.java
153
0.0
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/XmlMetadataTemplate.java

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/api/Admin.java
1
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/api/datadeposit/CollectionDepositManagerImpl.java
1
9.07
0.0% src/main/java/edu/harvard/iq/dataverse/api/imports/ImportGenericServiceBean.java
1
1.88
0.13% src/main/java/edu/harvard/iq/dataverse/DatasetServiceBean.java
1
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/DvObjectServiceBean.java
1
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/ImportDatasetCommand.java
1
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/PublishDatasetCommand.java
1
50.85
17.88% src/main/java/edu/harvard/iq/dataverse/pidproviders/PidUtil.java
1
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/settings/ConfigCheckService.java
1
50.94
-0.56% src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
2
0.0
0.0% src/main/java/edu/harvard/iq/dataverse/engine/command/impl/RegisterDvObjectCommand.java
4
0.0
-12.5% src/main/java/edu/harvard/iq/dataverse/settings/Setting.java
Jobs
ID Job ID Ran Files Coverage
1 #21725.1 06 Mar 2024 02:12PM UTC 883
20.58
Source Files on build #21725
  • Tree
  • List 883
  • Changed 51
  • Source Changed 50
  • Coverage Changed 42
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 44ce6a19 on github
  • Prev Build on develop
  • Next Build on develop
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc