safe-global / safe-client-gateway / 8171773380

89%

Build Type

push

github

Committed by web-flow

Commit Message

Guard adding/removing recovery contracts (#1247)

This adds guards to the following routes for addding/removing recovery contracts from Tenderly:

### `POST` `/v1/chains/:chainId/safes/:safeAddress/recovery`

A signature is required in order to successfully add a recovery contract. The following message need be signed (where ${} represents placeholder values for the respective data):

`enable-recovery-alerts-${chainId}-${safeAddress}-${moduleAddress}-${signer}-${timestamp}`

 To use this guard, the route should have:

- the `chainId` as part of the path parameters
- the `safeAddress` as part of the path parameters
- the `moduleAddress` as part of the JSON body (top level - unchanged)
- the `signer` as part of the JSON body (top level - new)
- the `Safe-Wallet-Signature` header set to the signature
- the `Safe-Wallet-Signature-Timestamp` header set to the signature timestamp

On top of this, the 'Safe-Wallet-Signature-Timestamp' need be within the past 5 minutes and the 'signer' an owner of the Safe.

### `DELETE` `chains/:chainId/safes/:safeAddress/recovery/:moduleAddress`

A signature is required in order to successfully remove a recovery contract. The following message need be signed (where ${} represents placeholder values for the respective data):

`enable-recovery-alerts-${chainId}-${safeAddress}-${moduleAddress}-${signer}-${timestamp}`

 To use this guard, the route should have:

- the `chainId` as part of the path parameters
- the `safeAddress` as part of the path parameters
- the `moduleAddress` as part of the JSON body (top level - unchanged)
- the `signer` as part of the JSON body (top level - new)
- the `Safe-Wallet-Signature` header set to the signature
- the `Safe-Wallet-Signature-Timestamp` header set to the signature timestamp

On top of this, the 'Safe-Wallet-Signature-Timestamp' need be within the past 5 minutes and the 'signer' an owner of the Safe.

Run Details

1742 of 2110 branches covered (82.56%)

Branch coverage included in aggregate %.

41 of 45 new or added lines in 4 files covered. (91.11%)

1 existing line in 1 file now uncovered.

6445 of 6677 relevant lines covered (96.53%)

346.43 hits per line