babelfish-for-postgresql / babelfish_extensions / 8156793662

74%

BABEL_5_X_DEV: 75%

push

github

Call pltsql_predicate_transformer for NOT expr argument (#2409)

In pltsql_predicate_transformer we recursively call the function for arguments for AND / OR clause. We did not do this
for NOT clause because of that there were cases where LIKE operator inside a NOT clause was not transformed.

example: SELECT COUNT(*) FROM babel_4566 WHERE 1=1 AND NOT OBJECT_NAME(id) LIKE '%Blah%'
In this query the top clause is AND. So, we analyse its arguments individually. Then one of the predicates is a NOT
clause and previously we directly returned it without transforming its like operator. With this fix, the arguments of NOT
will again be passed to pltsql_predicate_transformer for further break down and transformation.

As a fix, we handle NOT clause similar to AND/OR and call the pltsql_predicate_transformer recursively for its
argument. NOT clause only has one argument, but ipltsql_predicate_transformer still needs to be called for its
argument again.

Task: BABEL-4566
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

3 of 3 new or added lines in 1 file covered. (100.0%)

40468 of 55715 relevant lines covered (72.63%)

57678.49 hits per line