Qiskit / qiskit / 8144797151

89%

main: 89%

Build Type

Pull #11945

github

Committed by mergify[bot]

Commit Message

Fix performance issue in parsing bit indices in QPY (#11944)

* Fix performance issue in parsing bit indices in QPY

This commit fixes a performance issue in the deserialization of QPY
payloads. Previously when parsing every instruction the deserialization
would build up a dictionary of indices to bits so that when we load the
bit index in the qargs and cargs for each instruction. This mean the
worst case scaling of this section was O(n * m) for n instructions and
m bits, which for very large circuits could end up dominating the time
spent in deserialization. However, this was unecessary work because it
is rebuilding a mapping from index to bit as a dictionary, but that
mapping already existed in the bit lists the circuit is carrying around.
This commit fixes the performance issue by removing the dictionary
generation and just using the bit lists directly.

* Add release note

* Simplify logic

(cherry picked from commit f4b50fbb2)

Pull Request Pull Request #11945: Fix performance issue in parsing bit indices in QPY (backport #11944)

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

31 existing lines in 2 files now uncovered.

58878 of 65974 relevant lines covered (89.24%)

185402.53 hits per line