ubiquity / ubiquity-dollar / 8116927881

84%

Build Type

push

github

Committed by web-flow

Commit Message

chore: Fix review (#907)

* fix: deprecate incentive on dollar token

* chore: update

* chore: update

* Fix set role admin (#880)

* feat: add setRoleAdmin to AccessControlFacet

The setRoleAdmin can be only accessed by the admin.

* feat: add setRoleAdmin to AccessControl interface

* test: add testSetRoleAdmin_ShouldSetAdminRoleForGivenRole test

* feat: update access control for setRoleAdmin

* test: fix ShouldSetAdminRoleForGivenRole and add test for revert

* feat: add getRedeemCollateralBalance() method

* fix: remove balanced reserves check (#883)

* fix: limit AMO minter borrow amount (#882)

* fix: limit AMO minter borrow amount

* test: assert free collateral amount

* fix: do not allow to mint dollar with zero collateral

Resolves: https://github.com/sherlock-audit/2023-12-ubiquity-judging/issues/207

* test: add testMintDollar_ShouldRevert_IfZeroCollateralAvailable

* test: update comment in zero collateral mint test

* Update block count in a week (#891)

* feat: implement BlocksInWeek script task

The BlocksInWeek task provides a very close approximate of number of
blocks mined during one week.

Supported networks: mainnnet, sepolia.

Example usage:

npx tsx scripts/task/task.ts BlocksInWeek --network=mainnet
npx tsx scripts/task/task.ts BlocksInWeek --network=sepolia

Resolves: https://github.com/sherlock-audit/2023-12-ubiquity-judging/issues/230

* feat: update weekly block count to 49930

Set weekly block count to 49930 as measured in February 2024

npx tsx scripts/task/task.ts BlocksInWeek --network=mainnet
...
Calculating number of blocks in the last week...
Recent average block time: 12 seconds
Estimated blocks in a week best case 50400
Produced 49930 blocks, 470 worst than the best case

Resolves: https://github.com/sherlock-audit/2023-12-ubiquity-judging/issues/230

* feat: rename task function to funcBlocksInAWeek

As proposed during pull request review.

*... (continued)

Coverage Stats

243 of 364 branches covered (66.76%)

Branch coverage included in aggregate %.

26 of 37 new or added lines in 12 files covered. (70.27%)

6 existing lines in 3 files now uncovered.

1122 of 1414 relevant lines covered (79.35%)

190.91 hits per line