dwbutler / groupify / 173

99%

master: 97%

Build Type

push

travis-ci

Committed by David Butler

Commit Message

Fix member association filtering

When defining an association through a join table to a model using single table inheritance, ActiveRecord will always store the base class name in the join table. This allows the base class to always be correctly queried, but makes it challenging to correctly define an association that only returns a subclass.

Groupify groups define member associations using the `source_type` set correctly to the base class, but this returns all members of the base class instead of filtering to only members of the subclass. This fixes the issue by adding a filtering condition to the association on the `type` column, but only if STI is detected.

Run Details

30 of 30 new or added lines in 2 files covered. (100.0%)

1544 of 1557 relevant lines covered (99.17%)

767.36 hits per line