charmbracelet / bubbletea / 8098116801

76%

main: 72%

Build Type

Pull #897

github

Committed by aymanbagabas

Commit Message

feat: reduce console/term dependencies

Replace mattn/isatty and containerd/console with golang.org/x/term.

This mostly affects Windows. On Windows, unlike Unix, the console (TTY)
has different handles for input/output. Using the Console API, we need
to enable VT input on the input handle (CONIN) and VT processing on the
output handle (CONOUT). Doing so enables processing VT sequences on
Windows i.e. ANSI colors, mouse sequences, cursor movements, etc.

We already handle enabling VT processing for the program output using
Termenv `EnableVirtualTerminalProcessing`. For the input side, we enable
VT input right before setting the console to raw.

By doing this, we can drop both containerd/console and mattn/isatty.

Pull Request Pull Request #897: feat: reduce console/term dependencies

Run Details

10 of 16 new or added lines in 3 files covered. (62.5%)

4 existing lines in 2 files now uncovered.

1173 of 1547 relevant lines covered (75.82%)

198.72 hits per line