charmbracelet / bubbles / 8094780716

37%

master: 45%

Build Type

Pull #185

github

Committed by GabrielNagy

Commit Message

feat(textinput): do not block input on validation

This PR builds upon the excellent work in #167 and #114 and makes a
breaking change to the validation API.

Currently, validation will completely block text input if the Validate
function returns an error. This is now changed so the function no longer
blocks input if this is the case, thus handing this responsibility to
the clients.

This is helpful for cases where the user is requested to type an
existing system path, and the Validate function keeps asserting the
existence of the path. With the current implementation such a validation
is not possible.

For example:

    > /
    Err: nil

    > /t
    Err: /t: No such file or directory

    > /tm
    Err: /tm: No such file or directory

    > /tmp
    Err: nil

Pull Request Pull Request #185: feat(textinput): do not block input on validation

Run Details

0 of 17 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

1539 of 4196 relevant lines covered (36.68%)

57.67 hits per line