excaliburjs / Excalibur / 8090270083

89%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Firefox + Linux custom shader issue with glsl compiler attribute optimization (#2943)

This PR fixes an issue where Firefox on Linux would throw an error when using custom Materials due to unused attributes caused by glsl compiler optimization.


Before it would throw and crash excalibur

![image](https://github.com/excaliburjs/Excalibur/assets/612071/6b6a3f55-d260-4663-92d7-39ac8e3aa497)

Now after, it will log a warning because this is potentially a bug, or at minimum something you should look at

![image](https://github.com/excaliburjs/Excalibur/assets/612071/4eb162c2-b559-4923-81e7-8723b758de36)

Run Details

5284 of 6689 branches covered (79.0%)

17 of 34 new or added lines in 2 files covered. (50.0%)

5 existing lines in 1 file now uncovered.

11656 of 12780 relevant lines covered (91.21%)

23481.24 hits per line