Qiskit / qiskit / 8089864040

88%

Build Type

push

github

Committed by web-flow

Commit Message

Use const arrays for non-normalized basis in unitary synthesis (#11912)

* Use const arrays for non-normalized basis in unitary synthesis

This commit updates the the two_qubit_decompose rust module to use
const arrays for the underlying data in the transform_from_magic_basis
function used as part of computing the weyl coordinates of a unitary.
There was previously a `FIXME` comment to move these to compile time
variables. This commit implements this and removes the comment.

Another FIXME comment is removed about using the built-ins for zero and
one. There is no pattern to support that as the methods to return zero
and one are not const fns, so we can't use them in the context of this
PR. Previously with the dynamically allocated matrix objects we could
have used the `c64.zero()` and `c64.one()` methods from
`num_traits::Zero` and `num_traits::One` respectively (with faer 0.17.0
which added the trait impls) or `c64.faer_zero()` and `c64.faer_one()`,
but now that we've moved these arrays to const objects this no longer
applies.

* Remove stale code comment

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

15 existing lines in 2 files now uncovered.

59120 of 66202 relevant lines covered (89.3%)

243915.5 hits per line