safe-global / safe-client-gateway / 8077880516

89%

push

github

Make expireTimeSeconds non-optional (#1219)

- Makes the `expireTimeSeconds` of `ICacheService.set` a required parameter, thus reducing the likelihood of forgetting setting it (in most use cases, we want to set the expiration time).
- Setting the expiration time to `undefined` does not set the expiration time of the key, but the key will still be cached.
- Previously, if the key was `undefined` or not greater than 0, we would not save any entry in the cache. This can be confusing to the callers who might expect that calling `set` on the Cache actually sets a cache entry.
- If `set` is called multiple times on a specific cache entry, its TTL does not change (`NX` option). This option can be expanded in the future so that more control is given to the caller.

1670 of 1999 branches covered (83.54%)

Branch coverage included in aggregate %.

6141 of 6344 relevant lines covered (96.8%)

347.28 hits per line