rust-bitcoin / rust-bitcoin / 8066483503
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 87
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.951% (+0.04%) from 83.907%
8066483503

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#2508: Add `NetworkValidationError`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/7e2a81d03b2c4df158d58d32049fc71a69b4fcc7">7e2a81d03<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/36aa627d8312e87204a7628a9c954ca55750c55c"> Remove unused address::Error type (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a92dc9c35cd0b231d57bfa2915192bb1ab537bd5">a92dc9c35</a> Add NetworkValidationError (Tobin C. Harding)

Pull request description:

  Replaces #2502 because there is going  to be way too much arguing on this to bother a newer contributor with.

  This PR takes into consideration #2507 but does not improve the issue, it also does not make it worse. I propose to do this and then consider #2507 since this is a step forwards IMO.

  Remove the `address::Error` because its not good. Add a `NetworkValidationError` and return it from `require_network` - leaving the door open for resolving Kix's issue in 2507.

ACKs for top commit:
  Kixunil:
    ACK 7e2a81d03b2c4df158d58d32049fc71a69b4fcc7
  apoelstra:
    ACK 7e2a81d03b2c4df158d58d32049fc71a69b4fcc7

Tree-SHA512: 0a220dbec8b4d14dbe8bf131db4c83d3c0d

19438 of 23154 relevant lines covered (83.95%)

16687.12 hits per line

Jobs
ID Job ID Ran Files Coverage
1 8066483503.1 0
83.95
 GitHub Action Run
Source Files on build 8066483503
Detailed source file information is not available for this build.