btcsuite / btcd / 8060178922

57%

master: 55%

Pull #2128

github

blockchain: always relock chainLock for subscription callbacks

For various b.sendNotifcation() callbacks, if a runtime panic happens,
we don't get any useful debugging information since the error that
happens first is the "unlock of unlocked mutex" error.

This is because we temporarily unlock the chainLock for callbacks and
then relock them.  However, since the relocking code is executed after
the completion of the callback, if an error happens during that
callback, we never relock the chainLock.

Switching to an anonymous function and having the unlock code as a
defer will ensure that the lock always relocks.

15 of 15 new or added lines in 2 files covered. (100.0%)

29202 of 51474 relevant lines covered (56.73%)

456054.78 hits per line