rust-bitcoin / rust-bitcoin / 8031245340

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2480: Add a new base58 crate

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/aa8ba118ae04b601fec3331391ec301638030ba2">aa8ba118a Add a new base58 crate (Tobin C. Harding)

Pull request description:

  Add a new `base58check` crate to the workspace and move the `bitcoin::base58` module to it.

  Done as part of crate smashing, specifically so that we can make `bip32` into a separate crate.

ACKs for top commit:
  Kixunil:
    ACK aa8ba118ae04b601fec3331391ec301638030ba2
  apoelstra:
    ACK aa8ba118ae04b601fec3331391ec301638030ba2 though is this `pub mod` thing equivalent to `pub extern crate`?

Tree-SHA512: a8db97565ff0cfd677da5112962c47ff34a

19430 of 23133 relevant lines covered (83.99%)

16720.26 hits per line