btcsuite / btcd / 7986659361

57%

master: 55%

Build Type

Pull #2123

github

Committed by kcalvinalvin

Commit Message

blockchain: change reorg utxo cache behavior

The assumption in the previous code was incorrect in that we were
assuming that the chainLock is held throughout the entire chain reorg.
This is not the case since the chainLock is let go of during the
callback to the subscribers.

Because of this, we need to ensure that the utxo set is consistent on
each block disconnect. To achieve this, additional flushes are added
during block disconnects.

Also the utxocache is no longer avoided during block connects and when
we're checking for the validity of the block connects and disconnects as
we can just use the cache instead of trying to avoid it.

Pull Request Pull Request #2123: blockchain: fix inconsistent utxocache and database on reorg

Run Details

69 of 77 new or added lines in 2 files covered. (89.61%)

23 existing lines in 4 files now uncovered.

29261 of 51522 relevant lines covered (56.79%)

466146.55 hits per line