018dc657-a14c-4590-b1fe-e58ab1aec56c
72%

Ran 20 Feb 2024 12:09PM UTC

Jobs 1

Files 670

Run time 1min

Badge

Embed ▾

Committed 20 Feb 2024 11:47AM UTC coverage: 62.729% (+0.02%) from 62.705%

Build # 018dc657-a14c-4590-b1fe-e58ab1aec56c

Build Type

push

buildkite

Committed by

web-flow

Commit Message

Refactor history packages (#5673)

What changed?
Moving structs in the service/history package to their own packages

The handler is moved to it's own package with the interface (like in frontend)
The handler wrappers (grpc, and thrift) are moved to their own packages under wrapped (like in frontend)

The engine implementation is moved to it's own package as there was a circular dependency
history (service) -> handler -> history (engine)
and the engine implementation cannot be in the same package as the engine interface, as there is a dependency
engineimpl -> shard -> engine (Interface)

Moved all the error values in handler to a constants package as at least one of them (ErrRunIDNotValid) is referenced from two different packages (handler and engineimpl tests)

Why?
We should not have this much in the same package

Also when service and handler are in the same package we cannot introduce wrappers around handler in any other package than history as that will create a circular dependency:
history (service) -> wrapper -> history (handler)

How did you test it?
Ran unit tests

Potential risks
It just moves things around, so no real code changes

Release notes

Documentation Changes

Run Details

92630 of 147666 relevant lines covered (62.73%)

2309.17 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	018dc657-a14c-4590-b1fe-e58ab1aec56c.1	20 Feb 2024 12:09PM UTC	670	62.73

uber / cadence / 018dc657-a14c-4590-b1fe-e58ab1aec56c
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 018dc657-a14c-4590-b1fe-e58ab1aec56c

uber / cadence / 018dc657-a14c-4590-b1fe-e58ab1aec56c 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 018dc657-a14c-4590-b1fe-e58ab1aec56c

uber / cadence / 018dc657-a14c-4590-b1fe-e58ab1aec56c
72%

README BADGES
x