tarantool / tarantool / 7971658756

88%

push

github

fiber: don't hang on uncancellable client fiber

Similar to handling of uncancellable iproto request let's also panic on
uncancellable client fiber on shutdown.

Now `sql-tap/in2.test` start to fail under ASAN. `metrics_collector`
fiber of feedback_daemon is not cancelled in due time on shutdown.
Server panics and test fails. Turned out the fiber is cancelled during
metrics collection which is done under pcall. So cancelling is ignored
and we start the loop again going to sleep. fiber.sleep() will detect
cancel state after sleep but we panic before that moment.

We tried to make fiber.sleep() cancellation point but 2 tests start to
spin in busy loop (one of them is the test added in the patch).  So this
approach looks dangeous.

Part of #8423

NO_CHANGELOG=internal
NO_DOC=internal

66981 of 119476 branches covered (56.06%)

99426 of 114340 relevant lines covered (86.96%)

2661651.38 hits per line