MarkUsProject / Markus / 7950051800

92%

push

github

Section API-controller actions (#6955)

* actions-for-sections-api-controller

Added index, show, and update actions for the api controller of the sections model. I modified routes.rb (to actually establish the existence of these routes).

I realised that because of the MainApiController (which all the API controllers inherit), the SessionHandler.check_record method already ensures that an incoming request trying to do something with a particular record is valid (i.e. the record actually exists), so it would be redundant to check whether current_course.sections.find(params[:id]) for example returns a valid current_course.

* tests-for-section-api-controller

Added rspec tests for the update, index, and show actions of the api controller of sections. I tested both authorised and unauthorised requests, and for the GET requests (show and index), where either a json or xml response is expected, I tested that all necessary keys (corresponding to model attributes) are present, although I did not check whether the values of these attributes match between the responses and the original object data (not sure whether I should go this far). Also, for the #index request, some of my expectations perform an equality comparison between arrays; maybe it would be preferable to instead convert these to sets and make a comparison between sets.

422 of 1082 branches covered (39.0%)

Branch coverage included in aggregate %.

39026 of 41914 relevant lines covered (93.11%)

108.59 hits per line