rust-bitcoin / rust-bitcoin / 7917967798

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2436: Add unchecked variants to Amount and SignedAmount

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/df1d2f6eb5e94e57180573a5096e37424df98035">df1d2f6eb Add unchecked variants to Amount and SignedAmount (yancy)

Pull request description:

  The checked variants have worse performance than the unchecked variants due to the additional branching operations.  To improve performance where overflow is either not possible or not a concern, unchecked variants of `Amount` and `SignedAmount` are introduced for addition, subtraction and multiplication.

  Note, it seems the default behavior for the test framework is to panic on overflow, so I haven't figured out a good way to add tests for this.  Marking as a draft for now.

  closes: https://github.com/rust-bitcoin/rust-bitcoin/issues/2434

ACKs for top commit:
  Kixunil:
    ACK df1d2f6eb5e94e57180573a5096e37424df98035
  apoelstra:
    ACK df1d2f6eb5e94e57180573a5096e37424df98035 gonna go ahead and merge this, we can revisit if necessary when we look at `units` overflow behavior in general

Tree-SHA512: 3fbb0ec8166bee83c0582d8a8e34d5376fa

19433 of 23136 relevant lines covered (83.99%)

16706.52 hits per line