dart-lang / native / 7901634071
92%

DEFAULT BRANCH: main
Ran
Jobs 12
Files 139
Run time 7s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.684% (-0.001%) from 92.685%
7901634071

push

github

web-flow 
[native_assets_builder] Separate `KernelAsset`s from `Asset`s (#964)

There are multiple differences between the `native_assets.yaml` that is embedded in the kernel file and the `build_output.yaml -> assets`. 

* Based on the discussions on https://github.com/dart-lang/native/pull/955 and https://github.com/dart-lang/native/pull/946, it is clear that the `path` for assets should be in `Asset`, not in `AssetPath` for the file-path the asset has after the `build.dart` run. When the embedders (Flutter/Dart) embed the native assets mapping then the `path`s start representing the path on the system where the Dart/Flutter app is running. This should be embedded in the path-type there.
* The kernel info does not contain link mode (currently), as static linking is not supported. It's not clear that if we support static linking whether any information should be embedded in the kernel info at all.
* The native_assets.yaml for the kernel file is laid out for easy lookup at runtime (keyed on Target).
* We want to change the `Asset`s to output OS and Architecture instead of Target.

Therefore we should not share the data structure between `Asset`s and `KernelAsset`s (new name for the entries that are embedded via native_assets.yaml in a kernel file.)

This means that `dartdev` and `flutter_tools` will have to start converting `Asset`s to `KernelAsset`s when making the `native_assets.yaml` file. Therefore this is a breaking change and will have to be rolled into Dart and flutter/flutter manually.

8855 of 9554 relevant lines covered (92.68%)

17.28 hits per line

Subprojects
ID Flag name Job ID Ran Files Coverage
1 native_toolchain_c_windows 7901634071.1 18
88.5
 GitHub Action Run
2 native_assets_cli_macos 7901634071.2 19
100.0
 GitHub Action Run
3 native_toolchain_c_ubuntu 7901634071.3 18
73.38
 GitHub Action Run
4 native_assets_cli_windows 7901634071.4 19
99.52
 GitHub Action Run
5 native_assets_builder_ubuntu 7901634071.5 6
93.15
 GitHub Action Run
6 native_assets_cli_ubuntu 7901634071.6 19
100.0
 GitHub Action Run
7 native_assets_builder_windows 7901634071.7 6
93.15
 GitHub Action Run
8 native_toolchain_c_macos 7901634071.8 18
77.88
 GitHub Action Run
9 native_assets_builder_macos 7901634071.9 6
93.15
 GitHub Action Run
1 ffigen_macos 7770279454.1 47
91.83
 GitHub Action Run
2 jnigen_tests 7858255974.2 23
92.8
 GitHub Action Run
1 jni_tests 7858255974.1 26
88.18
 GitHub Action Run
Source Files on build 7901634071