tarantool / test-run / 7886315774

63%

push

github

Fix decoding error when reading server's log file

When a diff test starts a Tarantool server, test-run reads the server's
log file and tries to find the message indicating the server is ready.
Sometimes the server's log file may contain bytes that cannot be decoded
by `utf-8` codec and test-run fails with an error like this:

    [044] TarantoolInpector.handle() received the following error:
    [044] Traceback (most recent call last):
    [044]   File "/tarantool/test-run/lib/inspector.py", line 98, in handle
    [044]     result = self.parser.parse_preprocessor(line)
    [044]   File "/tarantool/test-run/lib/preprocessor.py", line 123, in parse_preprocessor
    [044]     return self.server(stype, sname, options)
    [044]   File "/tarantool/test-run/lib/preprocessor.py", line 351, in server
    [044]     return getattr(self, attr)(ctype, sname, opts)
    [044]   File "/tarantool/test-run/lib/preprocessor.py", line 209, in server_start
    [044]     self.servers[sname].start(silent=True, rais=True, wait=wait,
    [044]   File "/tarantool/test-run/lib/tarantool_server.py", line 910, in start
    [044]     self.wait_until_started(wait_load, deadline)
    [044]   File "/tarantool/test-run/lib/tarantool_server.py", line 1147, in wait_until_started
    [044]     self.wait_load(deadline)
    [044]   File "/tarantool/test-run/lib/tarantool_server.py", line 1131, in wait_load
    [044]     if not self.logfile_pos.seek_wait(msg, p, self.name, deadline):
    [044]   File "/tarantool/test-run/lib/tarantool_server.py", line 485, in seek_wait
    [044]     log_str = f.readline()
    [044]   File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/codecs.py", line 322, in decode
    [044]     (result, consumed) = self._buffer_decode(data, self.errors, final)
    [044] UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf0 in position 660: invalid continuation byte

At least, I have seen such errors when Tarantool... (continued)

760 of 1564 branches covered (48.59%)

Branch coverage included in aggregate %.

2938 of 4349 relevant lines covered (67.56%)

0.68 hits per line