Ran
|
Jobs
1
|
Files
94
|
Run time
7s
|
Badge
Embed ▾
README BADGES
|
push
github
Fix issue where carousel controls were no longer showing up (#1090) <!-- New Contributor? Welcome! We recommend you check your privacy settings, so the name and email associated with the commits are what you want them to be. See the contribution guide at https://github.com/lucyparsons/OpenOversight/blob/develop/CONTRIB.md#recommended-privacy-settings for more infos. Also make sure you have read and abide by the code of conduct: https://github.com/lucyparsons/OpenOversight/blob/develop/CODE_OF_CONDUCT.md If this pull request is not ready for review yet, please submit it as a draft. Please write your PR name in the present imperative tense. Examples of that tense are: "Fix issue in the dispatcher where…", "Improve our handling of…", etc. --> ## Description of Changes Copied over from https://github.com/OrcaCollective/OpenOversight/pull/409 The carousel controls are not showing up. This was caused by a commit that changed `paths` to `face_paths` https://github.com/lucyparsons/OpenOversight/pull/1070/files#diff-cb0d1be517e0623cb76d9d5557fe484e5 But the line controlling whether we show carousel controls is still using `paths`. https://github.com/OrcaCollective/OpenOversight/blob/7bf658c8d/OpenOversight/app/templates/partials/officer_faces.html#L21 This commit fixes this issue. ## Notes for Deployment N/A ## Screenshots (if appropriate) ## Tests and Linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
8462 of 9467 relevant lines covered (89.38%)
0.89 hits per line
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 7877788328.1 | 94 |
89.38 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|